Ruby 2.1 and 2.2 don't have support for frozen string literals

zombocom / derailed_benchmarks

Go faster, off the Rails - Benchmarks for your whole Rails app

2.96k stars 141 forks source link

Ruby 2.1 and 2.2 don't have support for frozen string literals #171

Closed elfotografo007 closed 3 years ago

elfotografo007 commented 4 years ago

The README and gemspec list this gem as compatible with ruby 2.1+. However, the frozen string literals syntax was introduced in ruby 2.3. Therefore, and error is raised when used in ruby 2.2.

Details of the error:

derailed_benchmarks-1.6.0/lib/derailed_benchmarks/require_tree.rb:43:in to_string': undefined method+@' for "TOP: 145.7539 MiB":String (NoMethodError)

Ruby version: 2.2.2 Gem version: 1.6.0.

schneems commented 4 years ago

That's a bug then, we can switch to String.new instead of +" if anyone wants to send a PR. Also we should probably move testing to circle ci and add Ruby 2.2 in our matrix

schneems commented 3 years ago

Fixed in 1.8.x