zombocom / puma_worker_killer

Automatically restart Puma cluster workers based on max RAM available
748 stars 77 forks source link

Add rack development dependency #27

Closed treble37 closed 8 years ago

treble37 commented 8 years ago
schneems commented 8 years ago

Can you drop that last number so it is 1.6 that way people aren't artificially limited to only a single minor release

treble37 commented 8 years ago

Done. It's a bit unclear to me though why now every single test failed on this build 33 (as opposed to build 32 with rack 1.6.4 specified https://travis-ci.org/schneems/puma_worker_killer/builds/112527109 where at least the ruby 2.x stuff seemed to pass). Also, these tests pass locally for ruby 1.9.3 and ruby 2.x (I tested on Ruby 2.3.0, for my "Ruby 2.x" local test)