search

zombocom / puma_worker_killer

Automatically restart Puma cluster workers based on max RAM available
748 stars 77 forks source link

JRuby fork not implemented issue #28

Closed treble37 closed 8 years ago

treble37 commented 8 years ago

1) In https://travis-ci.org/schneems/puma_worker_killer/jobs/112527114 there is:

Error: test_rolling_restart(PumaWorkerKillerTest): NotImplementedError: fork is not available on this platform org/jruby/RubyKernel.java:1881:infork'`

which is due to fork not being implemented in JRuby. (Edit: just noticed this is an allowed failure, but I'll leave this open because I'm also curious about #2 below)

2) Also, should Ruby 2.2 and 2.3 be added to the TravisCI tests? (mostly just a question for the author, I imagine Ruby 2.4.0dev, 2.2, and 2.3 are fairly similar). Thanks.

schneems commented 8 years ago

This gem doesn't work with jruby because jruby doesn't implement fork

schneems commented 8 years ago

We should remove jruby and add 2.3 and 2.2