search

zombocom / puma_worker_killer

Automatically restart Puma cluster workers based on max RAM available
748 stars 77 forks source link

Configurable reaper status logging #41

Closed daveallie closed 7 years ago

daveallie commented 8 years ago

Status lines like PumaWorkerKiller: Consuming 54.34765625 mb with master and 2 workers. fill up the puma logs pretty quickly.

This pull request adds a configuration option to optionally hide the status logs that Reaper displays every iteration.

daveallie commented 8 years ago

Test failure again due to this sort of situation: https://github.com/schneems/puma_worker_killer/pull/40#issuecomment-246846903

In the case where the random number is almost 10 seconds, when the rolling restarter is first called the app hasn't launched, then after it waits for about 10 seconds, it is too late as it has been 10 seconds since the WaitForIt block started; terminating the test.

Increases WaitForIt timeout would resolve these intermittent test failures.

schneems commented 8 years ago

Thanks for the PR. I'm fine with the idea, the tests on master are broken, need to get those fixed up before we can merge

daveallie commented 8 years ago

This is an issue with the master branch, extending the timeout for the RollingRestart test like suggested in https://github.com/schneems/puma_worker_killer/pull/40#issuecomment-246846903 would resolve the intermittent test failures.

Alternatively, just rerun this build.

daveallie commented 7 years ago

@schneems any chance of merging this in?

If you're still concerned about the status of the master branch, the most recent commit https://github.com/schneems/puma_worker_killer/pull/41/commits/01f8122f35741752b84997e411ae05eb0deed53a fixes the red builds.

schneems commented 7 years ago

Thanks!