is it proper to call ActiveRecord::Base.establish_connection when on_worker_boot

[wenbo]

as you can see, below is my condition. and puma will be rolling restart by the code PumaWorkerKiller.enable_rolling_restart.

I just wondering whether it is proper to call ActiveRecord::Base.establish_connection when on_worker_boot. I mean since on_worker_boot block will be executed every time rolling restart, I'm afraid that it may be run out of database's connection pool.

workers ENV.fetch("WEB_CONCURRENCY") { 2 }
before_fork do
  require 'puma_worker_killer'
  PumaWorkerKiller.enable_rolling_restart  # Default is every 6 hours

  # If you're preloading your application and using ActiveRecord, it's recommended that you close any connections to the database here to prevent connection leakage:
  ActiveRecord::Base.connection_pool.disconnect! if defined?(ActiveRecord)
end

preload_app!

# If you're preloading your application and using ActiveRecord, it's recommended that you setup your connection pool here:
on_worker_boot do
  ActiveSupport.on_load(:active_record) do
    ActiveRecord::Base.establish_connection
  end
end

[wenbo]

@schneems could you please have a look at above question.

[schneems]

It’s not required. AR will auto reconnect if it detects that the connection no longer works due to a fork. This behavior exists in Rails for a long time.