search

zombocom / puma_worker_killer

Automatically restart Puma cluster workers based on max RAM available
747 stars 77 forks source link

Test on recent rubies #84

Closed misdoro closed 4 years ago

misdoro commented 4 years ago

Test on recent minor ruby versions,

misdoro commented 4 years ago

@schneems I'm wondering if it would be better to migrate to github checks, something similar to what puma did: https://github.com/puma/puma/blob/master/.github/workflows/ruby.yml

WDYT ?

schneems commented 4 years ago

@schneems I'm wondering if it would be better to migrate to github checks, something similar to what puma did: https://github.com/puma/puma/blob/master/.github/workflows/ruby.yml

I'm for it. I'm not in love with travis. I believe though that 2.3.8 isn't present or there's some issues with it in github actions. My preference is CircleCI these days.

2.3.8 is working now. Can you update your PR to not remove it?

misdoro commented 4 years ago

Updated

schneems commented 4 years ago

thank you!