search

zompinc / efcore-extensions

Provides window (analytics) functions and binary functions for EF Core. Providers: SQL Server, SQLite, Postgres.
MIT License
60 stars 6 forks source link

Added AsSubQuery and changed target framework to 6 and MS.EFCore libr… #6

Closed Ephron-WL closed 6 months ago

Ephron-WL commented 1 year ago

…aries to 7.0.1 on base and SqlServer libraries.

Ephron-WL commented 1 year ago

The build of most projects in the solution will fail because I changed the only supported version of the base project to .net6 and dependent projects rely on it having a target framework of .net7. So, it is really up to you whether you want to support my target framework changes across all of your projects, just keep the AsSubQuery, or just reject the PR altogether.

virzak commented 1 year ago

.net6 and dependent projects rely on it having a target framework of .net7

That's no longer the case. Was fixed in #4 and currently no code needs .NET 7 except dotnet format. Build fails because of a spacing issue. Run dotnet tool restore, then yarn or npm install to create pre-commit hooks and spacing issues should be caught next time you commit.

Ephron-WL commented 1 year ago

Yeah, I didn't restart VS after syncing the repo. So, I see you had made that change.