search

zomux / deepy

A highly extensible deep learning framework
MIT License
422 stars 68 forks source link

RAE incorrect encode function #15

Open legin13 opened 8 years ago

legin13 commented 8 years ago

Hello! Thank you for your project, great job!

I have a trouble with encoding function in RAE. I'm new in Theano, so I could have mistaken, but I think the code in lines 51-53 is not valid: x_var should be a matrix and encode_func should contain x_var as argument, not x. So, I suppose the correct code will be:

        x_var = T.matrix()
        self._encode_func = theano.function([x_var], self.layers[0].encode_func(x_var),
                        allow_input_downcast=True, mode=theano.Mode(linker=THEANO_LINKER))

Sorry if I mistake.

zomux commented 8 years ago

Hi,

Actually, the code for RAE is very very old, and is not well tested.

I think you are right, I have to make a testcase for it and fix the problem.