search

zond / android-diplicity

Android client for the diplicity service.
https://diplicity-engine.appspot.com/
GNU General Public License v3.0
9 stars 8 forks source link

Fixes #25: Allow phase length entry in a more friendly manner. #56

Closed tttppp closed 7 years ago

tttppp commented 7 years ago

Fixes #25: Add a text entry for the quantity and a combo box for the units.

Also fix an issue when the phase length was not a number (e.g. when it was left blank).

tttppp commented 7 years ago

There are a couple of things wrong with this when I just tested it from the release apk.

  1. It suggested 1440 days as the starting value. Does the app remember what I last input maybe? Dev testing showed this working fine on the emulator - defaulting to 1 day each time.

  2. Cancelling the new game screen causes the soft keyboard to appear. I guess this is the code I added for displaying the soft keyboard, so I should check if that's really necessary.

zond commented 7 years ago

Also, the manual testing needs to be positive, of course :D

tttppp commented 7 years ago

Hopefully this is now fixed - I'll check when the new artifact is created.

Also I meant to say thanks for the review!

tttppp commented 7 years ago

I've manually verified this now. All looks good.