Map's zoom buttons overlap the next phase button

[zond]

Gah, annoying - the map zoom buttons are added by the web view and not positioned by the app. Where should we put the phase buttons instead?

On Aug 6, 2017 03:16, "GijsTimmers" notifications@github.com wrote:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/58, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddRaxxJ420Cg89lYmCUJkpONI4I2Jks5sVRQIgaJpZM4Oum1h .

[tttppp]

On my phone the map buttons take up half the width of the screen, so the only real option I can think of is to reduce the height of the web view slightly.

[zond]

Could move the phase change buttons to the top of the screen?

On Aug 6, 2017 09:26, "tttppp" notifications@github.com wrote:

On my phone the map buttons take up half the width of the screen, so the only real option I can think of is to reduce the height of the web view slightly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/58#issuecomment-320490763, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddcwGOEI17ou2VBjWzGl9xhvqmffvks5sVWqNgaJpZM4Oum1h .

[GijsTimmers]

I don't think there's many users who can't use pinch zoom nowadays, so you could consider disabling the buttons: https://stackoverflow.com/questions/10766669/how-to-remove-zoom-buttons-on-android-webview#10766678

[zond]

It's true, they might be redundant.

But I kind of liked outsourcing them completely to the web view renderer, and letting the developers of the web view decide :)

On Aug 6, 2017 10:15, "GijsTimmers" notifications@github.com wrote:

I don't think there's many users who can't use pinch zoom nowadays, so you could consider disabling the buttons: https://stackoverflow.com/ questions/10766669/how-to-remove-zoom-buttons-on-android-webview#10766678

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/58#issuecomment-320492777, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddfak-dKsQdYxwFuNI9topLASqSopks5sVXYngaJpZM4Oum1h .

[flurbius]

Eventually, put a checkbox in the app settings page, for now just turn them off by default.

As a work around if you don't touch the map for a few seconds they go away.

[flurbius]

OK I propose to squash this by the following method

phase 1: Remove the map controls phase 2: Re-organise settings (i will find the issue and update this with a link) insert a checkbox to allow the user to bring back the map zoom controls.

Any objections?

[zond]

SGTM

On Aug 21, 2017 15:27, "flurbius" notifications@github.com wrote:

OK I propose to squash this by the following method

phase 1: Remove the map controls phase 2: Re-organise settings (i will find the issue and update this with a link) insert a checkbox to allow the user to bring back the map zoom controls.

Any objections?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/58#issuecomment-323743950, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddeFznSN7upCGoBpVTOEGLlyyLRQxks5saYXSgaJpZM4Oum1h .

[GijsTimmers]

SGTM

[zond]

Fixed in https://github.com/zond/android-diplicity/commit/e5bb4dea10faf10e3992808c611384f299708e94