search

zond / android-diplicity

Android client for the diplicity service.
https://diplicity-engine.appspot.com/
GNU General Public License v3.0
9 stars 8 forks source link

Fixed end date #68

Open Enriador opened 7 years ago

Enriador commented 7 years ago

What about being able to determine a fixed end date for games? That would be useful for tournaments and amateur short games alike.

For example, to set the end date to 1907 (Fall Retreat). It would award a solo victory to the player with most centers, in line with the "Short Game" rule Allan Calhamer wrote in the official rules up to 2008.

What do you think? Is it feasible?

zond commented 7 years ago

Sure, it's feasible, and a good idea too!

As usual, it just lacks someone to implement it. Are you volunteering? :D

On Oct 8, 2017 15:01, "Enriador" notifications@github.com wrote:

What about being able to determine a fixed end date for games? That would be useful for tournaments and amateur short games alike.

For example, to set the end date to 1907 (Fall Retreat). It would award a solo victory to the player with most centers, in line with the "Short Game" rule Allan Calhamer wrote in the official rules up to 2008.

What do you think? Is it feasible?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddSQW_9BroRr-rJK7nOIOXthuNx-Wks5sqMe-gaJpZM4PxsmH .

Enriador commented 7 years ago

I would like to! Just point me in the right direction and I will try my best.

Gonna need some support though, my coding experience so far is limited to light modding :P

Em 08/10/2017 14:06, "zond" notifications@github.com escreveu:

Sure, it's feasible, and a good idea too!

As usual, it just lacks someone to implement it. Are you volunteering? :D

On Oct 8, 2017 15:01, "Enriador" notifications@github.com wrote:

What about being able to determine a fixed end date for games? That would be useful for tournaments and amateur short games alike.

For example, to set the end date to 1907 (Fall Retreat). It would award a solo victory to the player with most centers, in line with the "Short Game" rule Allan Calhamer wrote in the official rules up to 2008.

What do you think? Is it feasible?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddSQW_9BroRr- rJK7nOIOXthuNx-Wks5sqMe-gaJpZM4PxsmH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68#issuecomment-335005461, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae0TqZ3Mb8V-YgRZnEnWd4PtyhqTMb8Hks5sqMjTgaJpZM4PxsmH .

zond commented 7 years ago

Ok :)

First, you need to check out and run the server locally. I think the instructions on GitHub are ok for that. Building the client locally and running it against your local server is also recommended.

Then you need to add a field to https://github.com/zond/ diplicity/blob/master/game/game.go#L344 to contain the info for the game object, e.g. an 'int EndYear', where 0 means "no particular end year".

Then you need to add support for that to the client, i.e. https://github.com/zond/android-diplicity/blob/master/ app/src/main/java/se/oort/diplicity/MainActivity.java#L124 and https://github.com/zond/android-diplicity/blob/master/ app/src/main/res/layout/create_game_dialog.xml and maybe other pieces.

Finally you need to modify the phase shift logic to check the end year too, somewhere in https://github.com/zond/diplicity/blob/master/game/phase.go#L572.

On Oct 8, 2017 15:10, "Enriador" notifications@github.com wrote:

I would like to! Just point me in the right direction and I will try my best.

Gonna need some support though, my coding experience so far is limited to light modding :P

Em 08/10/2017 14:06, "zond" notifications@github.com escreveu:

Sure, it's feasible, and a good idea too!

As usual, it just lacks someone to implement it. Are you volunteering? :D

On Oct 8, 2017 15:01, "Enriador" notifications@github.com wrote:

What about being able to determine a fixed end date for games? That would be useful for tournaments and amateur short games alike.

For example, to set the end date to 1907 (Fall Retreat). It would award a solo victory to the player with most centers, in line with the "Short Game" rule Allan Calhamer wrote in the official rules up to 2008.

What do you think? Is it feasible?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddSQW_9BroRr- rJK7nOIOXthuNx-Wks5sqMe-gaJpZM4PxsmH .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68# issuecomment-335005461, or mute the thread https://github.com/notifications/unsubscribe-auth/Ae0TqZ3Mb8V- YgRZnEnWd4PtyhqTMb8Hks5sqMjTgaJpZM4PxsmH .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/68#issuecomment-335005697, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddTbDIMpY6S_a0cZTx5NKTdHj4ZYlks5sqMnYgaJpZM4PxsmH .