search

zond / android-diplicity

Android client for the diplicity service.
https://diplicity-engine.appspot.com/
GNU General Public License v3.0
9 stars 8 forks source link

Bug: RDY button doesn't update #88

Open GijsTimmers opened 5 years ago

GijsTimmers commented 5 years ago

How to reproduce:

  1. Make sure you are the last person to commit;
  2. Press the RDY button in the left upper corner of the screen
  3. Press the hamburger menu button in the left upper corner of the screen, press "Phases", select the current phase
  4. The RDY button will stay set. This is invalid; I'm not ready in fact and the text should be striked.
zond commented 5 years ago

Good catch!

On Sun, Jan 6, 2019, 20:53 GijsTimmers <notifications@github.com wrote:

How to reproduce:

  1. Make sure you are the last person to commit;
  2. Press the RDY button in the left upper corner of the screen
  3. Press the hamburger menu button in the left upper corner of the screen, press "Phases", select the current phase
  4. The RDY button will stay set. This is invalid; I'm not ready in fact and the text should be striked.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/88, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddf24BoOxn2um9wwIchPat9A5cJQnks5vAlQagaJpZM4ZylBN .

zond commented 5 years ago

Might be fixed in https://github.com/zond/android-diplicity/commit/b1d28216cc9c914a3408d13bc1061ae387a03112

zond commented 5 years ago

Pushed https://github.com/zond/android-diplicity/commit/b1d28216cc9c914a3408d13bc1061ae387a03112 to the beta release track.

Join the beta program in Play Store to check it out. If it works as intended, close this issue :)

GijsTimmers commented 5 years ago

I joined the beta program a few days ago and have been able to test a few times now by committing as the last player. Sometimes, it works, sometimes it doesn't. For instance I just committed as latest player, went into retreat, and the RDY button stays activated for some reason.

zond commented 5 years ago

If you don't have any orders to give you are automatically ready, could that be it?

On Fri, Jan 11, 2019, 20:06 GijsTimmers <notifications@github.com wrote:

I joined the beta program a few days ago and have been able to test a few times now by committing as the last player. Sometimes, it works, sometimes it doesn't. For instance I just committed as latest player, went into retreat, and the RDY button stays activated for some reason.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/88#issuecomment-453623746, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddWTuLpbuT3VxjlYuJRqX_Dh_6pE6ks5vCODHgaJpZM4ZylBN .

GijsTimmers commented 5 years ago

No... I actually had to do a retreat move in this game.

Op vr 11 jan. 2019 21:23 schreef zond notifications@github.com:

If you don't have any orders to give you are automatically ready, could that be it?

On Fri, Jan 11, 2019, 20:06 GijsTimmers <notifications@github.com wrote:

I joined the beta program a few days ago and have been able to test a few times now by committing as the last player. Sometimes, it works, sometimes it doesn't. For instance I just committed as latest player, went into retreat, and the RDY button stays activated for some reason.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/zond/android-diplicity/issues/88#issuecomment-453623746 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAAddWTuLpbuT3VxjlYuJRqX_Dh_6pE6ks5vCODHgaJpZM4ZylBN

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/88#issuecomment-453646225, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7WGv5LU2i8gafat4qAGXzeg4h5XHffks5vCPK3gaJpZM4ZylBN .

zond commented 5 years ago

Hm, so a simple redraw didn't help. I guess I have to test it out for real :0

On Fri, Jan 11, 2019, 21:37 GijsTimmers <notifications@github.com wrote:

No... I actually had to do a retreat move in this game.

Op vr 11 jan. 2019 21:23 schreef zond notifications@github.com:

If you don't have any orders to give you are automatically ready, could that be it?

On Fri, Jan 11, 2019, 20:06 GijsTimmers <notifications@github.com wrote:

I joined the beta program a few days ago and have been able to test a few times now by committing as the last player. Sometimes, it works, sometimes it doesn't. For instance I just committed as latest player, went into retreat, and the RDY button stays activated for some reason.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <

https://github.com/zond/android-diplicity/issues/88#issuecomment-453623746

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAAddWTuLpbuT3VxjlYuJRqX_Dh_6pE6ks5vCODHgaJpZM4ZylBN

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/zond/android-diplicity/issues/88#issuecomment-453646225 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AA7WGv5LU2i8gafat4qAGXzeg4h5XHffks5vCPK3gaJpZM4ZylBN

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/88#issuecomment-453649410, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddRdBryFFgRWrWBt6o6M7vj9C0taxks5vCPYjgaJpZM4ZylBN .