search

zond / android-diplicity

Android client for the diplicity service.
https://diplicity-engine.appspot.com/
GNU General Public License v3.0
9 stars 8 forks source link

Suggestion: move to latest phase when the game moves on when committing as last person #89

Open GijsTimmers opened 5 years ago

GijsTimmers commented 5 years ago

As of now, when committing as the last person, you will have to manually move to the latest phase. This could be improved. Three suggestions:

  1. Move to latest phase automatically
  2. Show the result of this phase; i.e. show everybody's orders
  3. Make the "Next Phase" and "Last Phase" button in the lower right corner of the screen active
zond commented 5 years ago

  1. I'm not wholly sure about - changing phase automatically might be surprising. Maybe only if you are the last one to commit?

  2. Isn't the new map more relevant in this case?

  3. Should definitely be fixed! Good catch.

On Sun, Jan 6, 2019, 20:54 GijsTimmers <notifications@github.com wrote:

As of now, when committing as the last person, you will have to manually move to the latest phase. This could be improved. Three suggestions:

  1. Move to latest phase automatically
  2. Show the result of this phase; i.e. show everybody's orders
  3. Make the "Next Phase" and "Last Phase" button in the lower right corner of the screen active

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/89, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddXVEG0CaZ4Eb728iromlxiJJh1e_ks5vAlSOgaJpZM4ZylE8 .

tttppp commented 5 years ago

For 2 I think showing everyone's orders is more useful than automatically advancing to the next phase. I usually click back to find out what other people did (and also what I tried to do since I forget quickly!)

GijsTimmers commented 5 years ago

@tttppp yes, to be honest, that's my preference, too.

zond commented 5 years ago

Patches are welcome :)

On Mon, Jan 7, 2019, 21:58 GijsTimmers <notifications@github.com wrote:

@tttppp https://github.com/tttppp yes, to be honest, that's my preference, too.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/zond/android-diplicity/issues/89#issuecomment-452079449, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAddYJItJI72KJBi2QXVRtCBs3csyivks5vA7UCgaJpZM4ZylE8 .

zond commented 5 years ago
  1. Might be fixed in https://github.com/zond/android-diplicity/commit/b1d28216cc9c914a3408d13bc1061ae387a03112
zond commented 5 years ago

Pushed b1d2821 to the beta release track.

Join the beta program in Play Store to check it out. If it works as intended, consider item 3. to be fixed.

GijsTimmers commented 5 years ago

I just tested this over the last couple of days. I really really like showing the phase's result first and would even suggest making this the default; it feels logical.

Bulllet 3. seems to be fixed, indeed. Thank you!