zond / dipact

GNU General Public License v3.0
12 stars 7 forks source link

Mute game button #104

Open JorenC opened 4 years ago

JorenC commented 4 years ago

After elimination, you'll receive a lot of messages from old chats.

We need to find a way to stop the players from being bothered if they're out of a game (e.g. mute the game and actively ask for it when loading the game screen when you're dead but the game is still open

zond commented 4 years ago

We could add a "settings" action to the message notifications, that takes you to the game metadata view (with all the mute buttons)?

JorenC commented 4 years ago

Could be, but there already is a settings from Android (which will mute all messages, and we don't want the user to use that). Might be too confusing.

JorenC commented 4 years ago

Also, I think the user still wants to listen to SOME of the conversations. Then maybe better a "mute channel" options per channel?

zond commented 4 years ago

The mute was originally to mute abusive players, so it doesn't have a channel option, only a player option. Is a channel option important? It's more work to build :/

JorenC commented 4 years ago

We could also do a mute game button, if that is easier.

Mute channel was a suggestion, but either way is fine.

On Tue, 28 Apr 2020, 08:30 zond, notifications@github.com wrote:

The mute was originally to mute abusive players, so it doesn't have a channel option, only a player option. Is a channel option important? It's more work to build :/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/dipact/issues/104#issuecomment-620408179, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXURGP6MWQW3NE5GQK3AP3ROZZXXANCNFSM4MSC7AZA .

zond commented 4 years ago

Mute game is simple to implement with the current API, since it's just "mute everyone" :)

zond commented 4 years ago

So, I was going to build this, but realised I don't know where to put it. Where does this button live?

JorenC commented 4 years ago

I think it can live in the new "Game settings" screen (see https://github.com/zond/dipact/issues/175).

It should be a toggle (mute/unmute)