zond / godip

A dippy adjudicator in Go.
GNU General Public License v3.0
27 stars 22 forks source link

Unify how phase messages and order corroboration handles build/disband order needs. #108

Closed zond closed 3 years ago

zond commented 3 years ago

Right now, phase messages take home SCs into account (regardless of whether the variant needs that!), while the corroboration doesn't.

I want them both to use one method (i.e. orders.AdjustmentStatus), but with some logic that handles the variant differences. E.g. letting the validator know which variant it's validating (which would be kind of useful anyway), or sending the parser as an argument, or something.

zond commented 3 years ago

Fixed in https://github.com/zond/godip/commit/3dea7874209c7d9c0d825c97c440bfa2e5c9dcc2