search

zond / godip

A dippy adjudicator in Go.
GNU General Public License v3.0
27 stars 22 forks source link

Implemented the missing rule "convoyed units can not break support against the convoy". #133

Closed zond closed 3 years ago

zond commented 3 years ago

See #132 and #128.

@tttppp, @TimothyJones, @RoganJosh, @jensforsgard PTAL

I think this is necessary.

No tests failed, so evidently the adjudicator has worked fine without knowing about this rule :O

I guess that's since the paradoxes the lack of the rule caused were resolved the same way as the rule resolved them.

I added a new test that fails if the code isn't there, anyway, so now we know this rule is implemented.

zond commented 3 years ago

Err, I don't know why I said no tests fail. I must have made some strange mistake. Lots of tests fail.

zond commented 3 years ago

Ah, I found the problem. Now it seems to work.

zond commented 3 years ago

I honestly think this is a nobrainer, so I'll probably merge this soon.