search

zond / godip

A dippy adjudicator in Go.
GNU General Public License v3.0
27 stars 22 forks source link

Dominance rules when computing non-SC dominance #137

Closed zond closed 3 years ago

zond commented 3 years ago

@JorenC, @tttppp, @johnpooch WDYT?

This should cover the variant-related hardcoding in https://github.com/zond/dipact/pull/273/files right?

tttppp commented 3 years ago

It looks fine. I've not investigated much, because I don't plan to use the feature, but is there a write up of the logic somewhere? Eg. If Austria takes Munich (but everything else stays the same) then does Burgundy suddenly stop belonging to France?

zond commented 3 years ago

@JorenC will have to answer these questions :D

Wulfheart commented 3 years ago

Could you also make a PR to the go library?

JorenC commented 3 years ago

Where do you want me to put the write-up?

Yes. The influencedby describes the state in which the the province will change to the normal rules, only if all are in effect (OR neutral SCs belong to the dominator).

So if Austria picks Munich, Burgundy follows normal logic and becomes contested (it is now a front line). If France captures Munich again, normal logic applies and it becomes French (I'm disregarding Belgium for simplicity's sake). If Germany recaptures Munich, it becomes French again, like the start. That's why I didn't only define the French influencing provinces but also any other SCs that it's people are "long term friends with". While this is maybe not ideal from the "we want to update the map as we go", it's the cheapest because doesn't need knowledge of the game history, and these events will less likely and to me totally acceptable - it's an aesthetic feature only. Indeed, while watching through 10+ games it never came up as something that stands out...

On Mon, 30 Aug 2021, 11:28 zond, @.***> wrote:

@JorenC https://github.com/JorenC will have to answer these questions :D

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/zond/godip/pull/137#issuecomment-908190775, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXURGKI2FX2ZCEDWAZNHSLT7NFMJANCNFSM5DBHNZKA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zond commented 3 years ago

Could you also make a PR to the go library?

This is a PR to the go library?

zond commented 3 years ago

Where do you want me to put the write-up?

Do you mean the rules? Check this code out and complete the ExtraDominanceRules in the classical configuration. Then if you want to play around with more variants you can add similar setups in them as well.