search

zond / godip

A dippy adjudicator in Go.
GNU General Public License v3.0
27 stars 22 forks source link

Long Names #86

Closed JorenC closed 4 years ago

JorenC commented 4 years ago

Added long names for all the maps. Fixed typos in some of the map SVGs.

zond commented 4 years ago

Sorry about the close/open, I pressed the wrong button.

I noticed that you used Inkscape to change the typos on the maps - that's a bit dangerous, since Inkscape sometimes changes other things.

I'll try to cherry pick the relevant changes...

zond commented 4 years ago

Alright, I cherrypicked all the long name things from your branch, but haven't touched the maps yet.

JorenC commented 4 years ago

Wallacia should be Wallachia (Google, only one is a land area)

On Mon, 1 Jun 2020, 11:46 zond, notifications@github.com wrote:

@zond commented on this pull request.

In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg https://github.com/zond/godip/pull/86#discussion_r433140061:

@@ -4707,7 +4734,7 @@ style="font-weight:bold;stroke-width:0.26458329px" id="tspan23176">Wall<tspan style="font-weight:bold;stroke-width:0.26458329px"

  • id="tspan23180">acia
  • id="tspan23180">achia

And this?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/godip/pull/86#pullrequestreview-421719542, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXURGLLKDAJYX24IS2YHZDRUN2HHANCNFSM4NPLMMRA .

JorenC commented 4 years ago

Same here.

It's called balearic sea, not Balea

On Mon, 1 Jun 2020, 11:46 zond, notifications@github.com wrote:

@zond commented on this pull request.

In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg https://github.com/zond/godip/pull/86#discussion_r433140011:

@@ -4278,7 +4305,7 @@ style="font-weight:bold;stroke-width:0.26458332px" id="tspan23011">e<tspan style="font-weight:normal;stroke-width:0.26458332px"

  • id="tspan23013">a
  • id="tspan23013">aric

What are these changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/godip/pull/86#pullrequestreview-421719477, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABXURGP4GOA5ZXC52XHP4ZTRUN2GVANCNFSM4NPLMMRA .

zond commented 4 years ago

I made you a new pull request with separate spelling fixes.

On Mon, Jun 1, 2020, 12:36 Joren notifications@github.com wrote:

Same here.

It's called balearic sea, not Balea

On Mon, 1 Jun 2020, 11:46 zond, notifications@github.com wrote:

@zond commented on this pull request.

In variants/empiresandcoalitions/svg/empiresandcoalitionsmap.svg https://github.com/zond/godip/pull/86#discussion_r433140011:

@@ -4278,7 +4305,7 @@ style="font-weight:bold;stroke-width:0.26458332px" id="tspan23011">e<tspan style="font-weight:normal;stroke-width:0.26458332px"

  • id="tspan23013">a
  • id="tspan23013">aric

What are these changes?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zond/godip/pull/86#pullrequestreview-421719477, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABXURGP4GOA5ZXC52XHP4ZTRUN2GVANCNFSM4NPLMMRA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zond/godip/pull/86#issuecomment-636773676, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAB25MDXEFLBAINANSNRKLRUOADNANCNFSM4NPLMMRA .