zone117x / node-multi-hashing

94 stars 582 forks source link

Support tests using mocha #85

Closed hackmod closed 4 years ago

hackmod commented 4 years ago

ready to merge

note

I do not rename the tests/ dir to test/ (mocha default)

zone117x commented 4 years ago

Great work! Could you add Github Actions for running these tests on Linux and Windows, and the versions node.jss we support?

hackmod commented 4 years ago

Great work! Could you add Github Actions for running these tests on Linux and Windows, and the versions node.jss we support?

Thanks for your feedback!!

I've never used Github workflow before. anyway, I've just made a new PR on my personal repo. https://github.com/hackmod/node-multi-hashing/pull/1

this is my setting: .github/workflows/node.js.yml

name: Node.js CI

on:
  push:
    branches: [ master ]
  pull_request:
    branches: [ master ]

jobs:
  build:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: [0.10.x, 4.x, 6.x, 8.x, 10.x, 12.x, 14.x]

    steps:
    - uses: actions/checkout@v2
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v1
      with:
        node-version: ${{ matrix.node-version }}
    - run: npm i
    - run: npm run build --if-present
    - run: npm test

image

after some test on it, I will post a new PR or simply add .github/workflows/node.js.yml

thanks in advance!

zone117x commented 4 years ago

Great! I enabled AppVeyor integration as well.

github-actions[bot] commented 4 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: