search

zone117x / node-multi-hashing

94 stars 582 forks source link

Invalid main field in package.json #96

Closed Vikasg7 closed 3 years ago

Vikasg7 commented 3 years ago

Fixed package.json for following warning. 

(node:6644) [DEP0128] DeprecationWarning: Invalid 'main' field in 'E:\Desktop\Nodejs\XXXX-XXXX\node_modules\multi-hashing\package.json' of 'multihashing'. 
Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)
Vikasg7 commented 3 years ago

@zone117x Could you please merge this when you have time? It will take away that warning from all the project which use this repo as a dependency.
Thanks!

Vikasg7 commented 3 years ago

Fixed Error: Module did not self-register. ERR_DLOPEN_FAILED when requireing the module twice in the project.
More explanation on this error here.
Fix was suggested here

P.S.
Applied work around is suggested in following links:
https://github.com/nodejs/nan/issues/844 https://github.com/nodejs/nan/blob/master/nan.h#L158

zone117x commented 3 years ago

Looks like this is failing to build or pass tests

zone117x commented 3 years ago

Looks like the scryptjane test vectors are failing. Is this related to the algo having some time component where it no longer works with a current date? Perhaps the that test should be disabled.

Vikasg7 commented 3 years ago

Not sure about scrypt jane, ScriptJane tests were already failing before I made my changes.

zone117x commented 3 years ago

Not sure about scrypt jane, ScriptJane tests were already failing before I made my changes.

Can you just disable the scrypt jane tests in your PR and then we can ensure everything else passes and we can merge.

Vikasg7 commented 3 years ago

Thanks for merging this.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: