search

zone117x / node-open-mining-portal

A scalable all-in-one easy to setup cryptocurrency mining pool and portal written entirely in Node.js.
GNU General Public License v2.0
1.02k stars 1.03k forks source link

TypeError: Cannot read property 'daemon' of undefined when disabling Bittrex #345

Open mindphuk opened 10 years ago

mindphuk commented 10 years ago

Seems Bittrex is the problem From https://bittrex.com/Home/Api

"V1 will be deprecated on 7/20. Please move to V1.1 immediately."

But when disabling Bittrex one gets this error:

TypeError: Cannot read property 'daemon' of undefined at /root/node-open-mining-portal/libs/profitSwitch.js:520:64 at Array.forEach (native) at /root/node-open-mining-portal/libs/profitSwitch.js:517:45 at Array.forEach (native) at getCoindDaemonInfo (/root/node-open-mining-portal/libs/profitSwitch.js:516:35) at /root/node-open-mining-portal/node_modules/async/lib/async.js:610:21 at /root/node-open-mining-portal/node_modules/async/lib/async.js:249:17 at iterate (/root/node-open-mining-portal/node_modules/async/lib/async.js:149:13) at /root/node-open-mining-portal/node_modules/async/lib/async.js:160:25 at /root/node-open-mining-portal/node_modules/async/lib/async.js:251:21 2014-07-26 08:23:06 [Master] [Profit] Profit switching process died, spawning replacement...

mindphuk commented 10 years ago

I have just edited libs/apiBittrex.js to use v1.1

var version         = '0.1.0',
    PUBLIC_API_URL  = 'https://bittrex.com/api/v1.1/public',
    PRIVATE_API_URL = 'https://bittrex.com/api/v1.1/market',
    USER_AGENT      = 'nomp/node-open-mining-portal'

And now it always throws this error:

TypeError: Cannot read property 'daemon' of undefined at /root/nomp/libs/profitSwitch.js:520:64 at Array.forEach (native) at /root/nomp/libs/profitSwitch.js:517:45 at Array.forEach (native) at getCoindDaemonInfo (/root/nomp/libs/profitSwitch.js:516:35) at /root/nomp/node_modules/async/lib/async.js:610:21 at /root/nomp/node_modules/async/lib/async.js:249:17 at iterate (/root/nomp/node_modules/async/lib/async.js:149:13) at /root/nomp/node_modules/async/lib/async.js:160:25 at /root/nomp/node_modules/async/lib/async.js:251:21

mindphuk commented 10 years ago

Ok looking in the code I found that it was my mistake, as I removed payoutProcessing from the coin pool config and therefore the property of the pool was undefined (I wanted to process payout with an external script so I removed it. Should have just set to false instead). Adding the info to the config fixed this issue so it can be closed.

However what remains is that bittrex api needs update.