zone117x / node-stratum-pool

High performance Stratum poolserver in Node.js
GNU General Public License v2.0
421 stars 853 forks source link

Found blocks in Bitcoin testnet with wrong coinbase address #157

Open pbipbi opened 6 years ago

pbipbi commented 6 years ago

I set "address" to my, but always found blocks in testnet (several times) with this coinbase "mqGucXZkq2Fp216qhUViqPXx5LVPJNEKf9". I cant understand where bitcoind/stratum get it?

HashUnlimited commented 6 years ago

That's because you are using a P2SH address for your "own" and the pool is decoding it without error but wrong. This behaviour is fixed in the dev branch.

pbipbi commented 5 years ago

Why this part of code not included to master branch?

HashUnlimited commented 5 years ago

indeed, nothing has been reported faulty. @zone117x what is your opinion?