zone117x / node-stratum-pool

High performance Stratum poolserver in Node.js
GNU General Public License v2.0
419 stars 853 forks source link

how often is "Stratum connection interrupted" #18

Closed bmatusiak closed 10 years ago

bmatusiak commented 10 years ago

im getting

debug: [client] Client 'workername' disconnected!

on my workers ... is anybody else experiencing this?

bmatusiak commented 10 years ago

on the miner side it says

Stratum connection timed out
Stratum connection interrupted
bmatusiak commented 10 years ago

i have tested this on multi machines , with same effect

vekexasia commented 10 years ago

hello @bmatusiak what is the coin you're testing?

bmatusiak commented 10 years ago

http://rubycoin.org/

zone117x commented 10 years ago

Can you provide more information? Are any valid shares being processed at all? What percent of miners get disconnected from this? What miner software are you using?

bmatusiak commented 10 years ago

@vekexasia also my config

https://gist.github.com/bmatusiak/0054aac2f0c3ffa52dd1

zone117x commented 10 years ago

First thing you should do is update to latest code because there is a good chance the issue has been fixed. Your config indicates old version :)

bmatusiak commented 10 years ago

yea i found shares, i found a block, i updated my gist with log file

bmatusiak commented 10 years ago

i git cloned yeaterday

bmatusiak commented 10 years ago

o i must had a older clone

when i updated i get this error


/home/bmatusiak/rubycoin/stratum/node-stratum2/lib/varDiff.js:51
    Object.keys(ports).forEach(function(port){
           ^
TypeError: Object.keys called on non-object
    at Function.keys (native)
    at new varDiff (/home/bmatusiak/rubycoin/stratum/node-stratum2/lib/varDiff.js:51:12)
    at SetupVarDiff (/home/bmatusiak/rubycoin/stratum/node-stratum2/lib/pool.js:72:25)
    at pool.start (/home/bmatusiak/rubycoin/stratum/node-stratum2/lib/pool.js:41:9)
    at Object.<anonymous> (/home/bmatusiak/rubycoin/stratum/stratum.js:110:6)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)
zone117x commented 10 years ago

You have an old config, look at the example config in the readme.

bmatusiak commented 10 years ago

k i updated to latest, i am gonna close this for now

zone117x commented 10 years ago

Also its easier to help you when you answer my debug questions :)

"Can you provide more information? Are any valid shares being processed at all? What percent of miners get disconnected from this? What miner software are you using?"

cgminer? I just committed an update to the stratum subscription reply which I think may fix your issue.

bmatusiak commented 10 years ago

im using 3 "minerd" and 1 "cgminer"

both are giving the interupted connection

minerd just sent this on latest

Stratum connection timed out
Stratum connection interrupted

its cant to find the version i have for minerd... but it has always worked for stratum mining

zone117x commented 10 years ago

If you could get a wireshark trace of the tcp packets between miner and server then we can very likely fix this problem. It looks like somehow the server isn't acknowledging some message from the miner.

bmatusiak commented 10 years ago

running wireshark now...

what expression did you want me to use?

atm im using expression tcp.dstport == 3335

3335 is the port stratum is listening on,, and im running wireshark on the machine with minerd

bmatusiak commented 10 years ago

this is new

C:\Users\bmatusiak\Desktop\minerd>minerd.exe --url stratum+tcp://192.168.0.17:3335 --user bmatusiak.1 -p 1 -t 3 --quie
t
[2014-03-06 18:27:26] Starting Stratum on stratum+tcp://192.168.0.17:3335
[2014-03-06 18:27:26] 3 miner threads started, using 'scrypt' algorithm.
[2014-03-06 18:29:12] accepted: 1/1 (100.00%), 11.17 khash/s (yay!!!)
[2014-03-06 18:29:37] Stratum detected new block
[2014-03-06 18:29:54] accepted: 2/2 (100.00%), 11.12 khash/s (yay!!!)
[2014-03-06 18:31:18] accepted: 3/3 (100.00%), 11.21 khash/s (yay!!!)
[2014-03-06 18:32:28] Stratum detected new block
[2014-03-06 18:33:59] accepted: 4/4 (100.00%), 11.26 khash/s (yay!!!)
[2014-03-06 18:35:14] accepted: 5/5 (100.00%), 11.31 khash/s (yay!!!)
[2014-03-06 18:36:08] Stratum detected new block
[2014-03-06 18:36:25] accepted: 6/6 (100.00%), 11.40 khash/s (yay!!!)
[2014-03-06 18:37:27] accepted: 7/7 (100.00%), 11.30 khash/s (yay!!!)
[2014-03-06 18:37:46] accepted: 8/8 (100.00%), 11.31 khash/s (yay!!!)
[2014-03-06 18:38:01] Stratum detected new block
[2014-03-06 18:38:26] accepted: 9/9 (100.00%), 11.17 khash/s (yay!!!)
[2014-03-06 18:38:55] accepted: 10/10 (100.00%), 11.18 khash/s (yay!!!)
[2014-03-06 18:39:21] accepted: 11/11 (100.00%), 11.30 khash/s (yay!!!)
[2014-03-06 18:41:22] Stratum connection timed out
[2014-03-06 18:41:22] Stratum connection interrupted
[2014-03-06 18:42:57] accepted: 12/12 (100.00%), 11.27 khash/s (yay!!!)
[2014-03-06 18:43:14] accepted: 13/13 (100.00%), 11.27 khash/s (yay!!!)
[2014-03-06 18:46:14] stratum_recv_line failed
[2014-03-06 18:46:14] Stratum connection interrupted
bmatusiak commented 10 years ago

ahh, ok im now following tcp stream raw data

bmatusiak commented 10 years ago

https://gist.github.com/bmatusiak/f91244b62dd505d7634a

is this what your looking for on wireshark?

zone117x commented 10 years ago

Can you update to the latest code again? I added data to the subscription response that may fix the issue. I see in the tcp log that its not using latest fix I did https://github.com/zone117x/node-stratum/commit/f43a5833cf24ec0b134e6f63cff47438d73aa45c

zone117x commented 10 years ago

If the problem still happens with my latest code, TheSeven (who is really good at fixing these types of things) says: "I'd suggest the tester to filter for your IP address ("ip.addr eq 123.123.123.123") and then export the visible packets to a capture file and attach that to the issue"

bmatusiak commented 10 years ago

yea i still get problem,

is this what your looking for? https://gist.githubusercontent.com/bmatusiak/3cfb9c35eb307e4a4fd2/raw/815565afb9589072ed264b0e0195ebd4a6d2b2b2/log3

zone117x commented 10 years ago

What's your connectionTimeout set to? Make it something really high like over 9000 because that could be causing your disconnect.

bmatusiak commented 10 years ago

so i set the timeout verry high "900000", still had a disconnect, it seems miner is causing the timeout after 120 sec of not sending any shares, i set the diff lower on pool and miner send more shares, but once it gets to a heavy share it still gets killed after the 120 sec

zone117x commented 10 years ago

[3:55:39 AM] TheSeven: the wireshark trace doesn't seem to be complete, it stops in the middle of frame 5187 [3:55:51 AM] TheSeven: up to that point there's no trace of the connectiong being closed by either side [3:58:02 AM] TheSeven: nothing unusual at all in that trace [3:58:35 AM] TheSeven: so either the trace stops before the problem occurred, or the problem is that the miner spuriously thinks that the connection was closed or something [3:58:45 AM] TheSeven: the first of which seems more likely

bmatusiak commented 10 years ago

i think the miner is just closing the connection on a heavy share, i see in the mimerd logs that it closes exactly 2 minits after previous share

bmatusiak commented 10 years ago

what irc channel are you on?

zone117x commented 10 years ago

TheSeven was helping over a skype private convo. Although I just created two irc channels for discussion on freenode, #nomp & #nomp-dev

bmatusiak commented 10 years ago

i found this

https://bitcointalk.org/index.php?topic=215441.msg2923337#msg2923337

i didnt see if node-stratum is doing this or not yet, and is mabe causing my issue

zone117x commented 10 years ago

https://github.com/zone117x/node-stratum/commit/4a088b19fc95ee7ca251a74944bc0e3947e8f2af

This should fix the issue. Please verify

iarcho commented 10 years ago

i get the same error debug: [ client] Client 'undefined' disconnected!

and the last fix does not fix it

bmatusiak commented 10 years ago

yes thanks!