search

zonear / isotope-perfectmasonry

PerfectMasonry extension for Isotope
137 stars 49 forks source link

Compatibility with Isotope 2.x #23

Open thewebists opened 10 years ago

thewebists commented 10 years ago

Is there any chance that this extension might get updated to work with Isotope 2.x?

Here's a jsfiddle of perfectmasonry on the latest Isotope release (v.2 beta 10): http://jsfiddle.net/thewebists/KbUpD/2/

mikkotikkanen commented 10 years ago

Hmm. Maybe. Any idea what has been changed/causes this in the new version?

alexanderfast commented 10 years ago

Stumbled upon this plugin and have the same issue as shown in the fiddle.

sciascia commented 10 years ago

We're seeing a similar thing, whenever we include perfect masonry, we see:

  TypeError: $.Isotope is undefined
  Error: No layout mode: perfectMasonry

If we comment out perfect masonry we obviously see that last layout error.

NoahTwine commented 9 years ago

I'll jump in here and second the idea of updating for Isotope 2.2. Looks to be a super plugin.

dastbelaraki commented 9 years ago

Any comment on Isotope 2.x compatibility yet? I get "Uncaught TypeError: Cannot read property 'prototype' of undefined" in console tab.

NoahTwine commented 9 years ago

If upgrading to 2.2 is a large project I'm sure some on this thread would be happy to pitch in.

mikkotikkanen commented 9 years ago

I'm not really using the plugin, created it for one time use but I supposed I could take a look at it, at least if it's not a major refactor.

mikkotikkanen commented 9 years ago

The 2.x documentation has no mention on extending Isotope so it looks like it's not officially supported in 2.x versions, which would mean hack job which then could break at any time when Isotope changes its internal workings. So it's not looking good. :/

dastbelaraki commented 9 years ago

Thank you for your reply mate :)

thewebists commented 9 years ago

Not sure what you guys need, but I ended up using the Packery layout mode, which is now available in Isotope 2.x. That solved all my problems with gaps in my Isotope grids.