Remove deprecated features related to locale

mattias-p commented 1 year ago

Purpose

This PR cleans up deprecations related to LANGUAGE.locale.

It fixes #1061. It integrates a commit from #1060 which cleans up one of the deprecations.

Feedback is improved when a unit test fails.
Specifying languages with country code in the RPC-API is no longer supported.
Specifying multiple locale tags with the same language code in LANGUAGE.locale is no longer supported.
Specifying LANGUAGE.locale with an empty value is no longer supported.
The _clear_LANGUAGE_locale and _add_LANGUAGE_locale methods are replaced with a _set_locales method.

Try starting zm-rpcapi with LANGUAGE.locale set to an empty value.
Try starting zm-rpcapi with LANGUAGE.locale including multiple locale tags with the same language code.
Try calling RPC-API methods with a language argument with an exact locale tag present in LANGUAGE.locale.

mattias-p commented 1 year ago

I fixed the broken test. I also changed the tag from V-Minor to V-Major because this is a breaking change.

marc-vanderwal commented 1 year ago

Release testing successful:

After setting LANGUAGE.locale to an empty value, attempting to start zm-rpcapi fails with an error about LANGUAGE.locale being empty.
After setting LANGUAGE.locale to fr_FR fr_BE, attempting to start zm-rpcapi fails with an error about a repeated language code.
After setting LANGUAGE.locale back to its default value and starting zm-rpcapi, calling the job_results method with language set to fr gives messages in French, but fr_FR fails with an Invalid language tag format error.