search

zonemaster / zonemaster-backend

The Zonemaster Backend - part of the Zonemaster project
Other
14 stars 23 forks source link

Remove client id and version #1122

Open mattias-p opened 1 year ago

mattias-p commented 1 year ago

Today job_create and batch_create take client_id and client_version parameters. We make the effort to document and validate them but then we just throw their values away. We should remove these parameters from both job_create and batch_create.

Edit: Up until now I was assuming that we were in fact persisting these arguments in the database, but apparently we don't. I've updated the title and description of this issue to reflect this fact.

Stabilization

Tracking issue

Affected interfaces

Incompatibly changed:

Dependencies

None

Overlapping proposals

None

matsduf commented 1 year ago

I see no traces of them in the database schema, but see #1116 where something like it is asked for.

mattias-p commented 1 year ago

Me neither! I just took for granted that we stored them in the test_results table since we make the effort to accept and validate them. I guess it's settled that it's not important then.

matsduf commented 1 year ago

client_id and client_version are meaningless, but the possibility to store "private data" in the table is requested for our batch tests.