Fix v2023.2 database migration script

tgreenx commented 8 months ago

Purpose

This PR proposes a fix to the database migration script of release v2023.2.

Changes

List::Util::zip() was only added in Perl v5.36. This makes use of List::MoreUtils::zip_unflatten() instead.
The script filename is also updated to the proper Zonemaster-Backend version.
The migration process for PostgreSQL has been heavily optimized in order to run successfully on production environments with a large test_results table.

How to test this PR

Run the script on (a copy of) Zonemaster’s database. The migration should yield exactly the same data (although the order of the rows in the new tables can’t be guaranteed and isn’t significant).

marc-vanderwal commented 7 months ago

After inspecting a few results of both old and recent test cases in the database I’ve used for testing this new migration script, it seems that the migration went well. The Delegation01 message argument migration also went through successfully. Now is a good time to review this script. :)

marc-vanderwal commented 7 months ago

After all testing the script will probably work for migration of Postgresql databases, but not much is common with Mysql. Are we confident that the script works for Mysql?

I’ve only conducted basic testing on MySQL (and a tiny dataset) when the first version of the script was tested for the previous release. I don’t have a large MySQL database on hand for testing, unfortunately.

matsduf commented 7 months ago

I think it is fine to go now.

zonemaster / zonemaster-backend