zonemaster / zonemaster-cli

The Zonemaster CLI - part of the Zonemaster project
Other
20 stars 21 forks source link

Long severity level translations break table layout in output #334

Closed mattias-p closed 1 year ago

mattias-p commented 1 year ago

Today the width of the severity column is calculated using a minimum width and the length of the translation of the severity column heading. However for some locales there are severity level names that are even longer. When messages are printed with such severity levels the table layout breaks down. E.g. when "WARNING" messages are printed in Spanish ("ADVERTENCIA").

A robust fix would be to calculate the width of the severity column by taking the maximum length of all the severities as well as the heading.

I guess it would be nice to have this fixed in this release (2023.1) but I don't think we should consider it blocking.

matsduf commented 1 year ago

Fixed by #335