search

zonemaster / zonemaster-cli

The Zonemaster CLI - part of the Zonemaster project
Other
20 stars 20 forks source link

Preparation for release v2023.1.3 (CLI) #348

Closed matsduf closed 1 year ago

matsduf commented 1 year ago

Purpose

Preparation for release.

Changes

Updates files Changes, Makefile.PL and CLI.pm.

How to test this PR

Review the changes.

tgreenx commented 1 year ago

This PR can be closed without merging if zonemaster/zonemaster#1194 is approved before the release of v2023.1.3.

Doesn't this PR will have to be merged no matter what, just because the required Engine version has changed? If so then I don't see how it relates to the issue mentioned with Docker.

matsduf commented 1 year ago

Doesn't this PR will have to be merged no matter what, just because the required Engine version has changed? If so then I don't see how it relates to the issue mentioned with Docker.

No, not if we follow the method proposed in https://github.com/zonemaster/zonemaster/pull/1194. Note that the version in Makefile.PL is the minimum version, and cpanm will take the highest version available.

matsduf commented 1 year ago

I suggest that we do not merge this and instead use the method proposed in https://github.com/zonemaster/zonemaster/pull/1194.

ghost commented 1 year ago

I suggest that we do not merge this

I do think it would make sense to update the CLI and Backend version during this fix release. The introduced bug in Zonemaster-Engine is critical enough to force the minimal required version in the other modules.

tgreenx commented 1 year ago

I suggest that we do not merge this

I do think it would make sense to update the CLI and Backend version during this fix release. The introduced bug in Zonemaster-Engine is critical enough to force the minimal required version in the other modules.

Agreed, I would prefer to do it this way as well.