search

zonemaster / zonemaster-engine

The Zonemaster Engine - part of the Zonemaster project
Other
33 stars 31 forks source link

Misleading wording on profile resolver.defaults.retry #1070

Open hannaeko opened 2 years ago

hannaeko commented 2 years ago

As reported on the mailing list, in the profile, retry refers to the total number of tries before the request is considered failed and should probably not include the initial query.

For instance the dig manual states

+tries=T This option sets the number of times to try UDP and TCP queries to server to T instead of the default, 3. If T is less than or equal to zero, the number of tries is silently rounded up to 1.

+retry=T This option sets the number of times to retry UDP and TCP queries to server to T instead of the default, 2. Unlike +tries, this does not include the initial query.

Should we make that distinction in the profile as well? Or at least make it so that retry does not count the initial attempt?

As we pass this parameter to LDNS as is, is this an issue that could better be resolved in Zonemaster::LDNS?

tgreenx commented 11 months ago

I would vote for keeping the current variable name (retry), make it not count the initial query, and change its documentation; it has the benefits of being in line with the LDNS functions, and a minimal change to Zonemaster-LDNS/Engine.

tgreenx commented 11 months ago

I have proposed #1258 as a solution.