Closed matsduf closed 4 months ago
@mattias-p, please re-review.
@mattias-p, could your re-review?
@tgreenx and @mattias-p, please re-review.
@mattias-p, @tgreenx and @marc-vanderwal, can you approve this? I would like to merge it. It updates TestUtils.pm and the unit tests that use it. They pass as expected.
I’ve had a look. I see no issues that haven’t already been brought up by @tgreenx.
@marc-vanderwal and @tgreenx, please re-review after my latest updates.
@marc-vanderwal and @tgreenx, please re-review after my latest updates. All tests pass. TestUtil now treats empty-empty as an error. Can this be merged now?
I have commited the proposal from @tgreenx and I have updated the documentation so that it states that empty-empty is not permitted. @marc-vanderwal and @tgreenx, please re-review.
@marc-vanderwal and @tgreenx, please re-review.
Purpose
This PR introduces two changes to function in TestUtil.pm:
t
file. Use croak() instead.The unit test files using TestUtil.pm have been updated to match the new format.
Five new scenarios have been added to Consistency05 and two to Consistency06. Both updates are to unit tests that uses the new function in TestUtil.pm that supports undelegated data.
The following new scenario fail:
Context
The update is needed for https://github.com/zonemaster/zonemaster/pull/1255.
How to test this PR
Review TestUtil.pm. If the unit test files using TestUtil.pm then they should be fine.