Fix undef eq comparison

zonemaster / zonemaster-engine

The Zonemaster Engine - part of the Zonemaster project

Other

34 stars 33 forks source link

Fix undef eq comparison #1363

Closed tgreenx closed 3 months ago

tgreenx commented 3 months ago

Purpose

This PR fixes an oversight from #1343.

Changes

Set default value of properties 'resolver.source{4,6}' in Profile.pm

How to test this PR

Checks should now pass.

mattias-p commented 3 months ago

I disagree with the premise of this PR. For the effective profile, all properties are always set, i.e. they have defined values. If $src_address is ever undef here then we have a bug in the profile module and we should fix it there instead.

mattias-p commented 3 months ago

Release testing for v2024.1

I've verified that the default profile contains the default values for "resolver.source4" and "resolver.source6".