search

zonemaster / zonemaster-engine

The Zonemaster Engine - part of the Zonemaster project
Other
34 stars 33 forks source link

Fix regression in Syntax04 #1369

Closed marc-vanderwal closed 3 months ago

marc-vanderwal commented 3 months ago

Purpose

This PR fixes a small regression caused by code refactoring.

Context

See #1368 (and the original changes that introduced the regression being addressed by this PR: #1322).

Changes

How to test this PR

Run the following two tests.

Firstly, run the following command:

perl -MZonemaster::Engine -E 'say join "\n", Zonemaster::Engine->test_method("syntax", "syntax04", "hipotel.fr");'

Expect one of the lines in the output to have a NAMESERVER_NON_ALLOWED_CHARS message like so:

Syntax:Syntax04:NAMESERVER_NON_ALLOWED_CHARS domain="100\\0321\\032443\\032sipdir.online.lync.com"

Secondly, run a complete test on hipotel.fr, either using zonemaster-cli hipotel.fr or from GUI. Expect an error message stating “Found illegal characters in the nameserver (100\0321\032443\032sipdir.online.lync.com).”.

matsduf commented 3 months ago

@marc-vanderwal, please merge.

marc-vanderwal commented 3 months ago

@marc-vanderwal, please merge.

Merging…