search

zonemaster / zonemaster-engine

The Zonemaster Engine - part of the Zonemaster project
Other
34 stars 33 forks source link

All requests are not properly cached #951

Open ghost opened 3 years ago

ghost commented 3 years ago

It seems that all requests performed within the Nameserver's module are not properly stored in cache. Replaying these tests will result in network traffic.

Storing the data with the CLI:

zonemaster-cli --save zonemaster.net.data zonemaster.net

Using the cache for each module independently, it seems that the leak comes from the Nameserver's tests and more precisely from Nameserver/Nameserver03, Nameserver/Nameserver08 and Nameserver/Nameserver09.

zonemaster-cli --test nameserver --restore zonemaster.net.data zonemaster.net
zonemaster-cli --test nameserver/nameserver03 --restore zonemaster.net.data zonemaster.net
zonemaster-cli --test nameserver/nameserver08 --restore zonemaster.net.data zonemaster.net
zonemaster-cli --test nameserver/nameserver09 --restore zonemaster.net.data zonemaster.net

Addresses https://github.com/zonemaster/zonemaster-backend/issues/828

vlevigneron commented 2 years ago

nameserver03 uses AXFR, which is not cached, Cf zonemaster/zonemaster-engine#189 nameserver08 and nameserver09 use randomized case domain names, which prevent them to be cached. This randomization can be fixed if we use a fixed pattern for upper/lower cases, I'm not sure this randomization is mandatory. If I fix the problem for nameserver8 and nameserver9, I propose to close this issue. nameserver03 being covered with zonemaster/zonemaster-engine#189

matsduf commented 2 years ago

This randomization can be fixed if we use a fixed pattern for upper/lower cases, I'm not sure this randomization is mandatory. If I fix the problem for nameserver8 and nameserver9, I propose to close this issue. nameserver03 being covered with #189

For Nameserver08 it is mandatory, but not Nameserver09. I have created issue zonemaster/zonemaster#1009.