Fix notifications behaviour - Githubissues

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project

Other

14 stars 23 forks source link

Fix notifications behaviour #369

Closed hannaeko closed 1 year ago

hannaeko commented 1 year ago

Purpose

Fix notifications behaviour.

Context

The notifications were displayed behind the navigation bar. (introduced in #365, spotted in https://github.com/zonemaster/zonemaster-gui/pull/364#pullrequestreview-1197123148)
Success notifications were not displayed when the test was started from the result page (introduced in #257 / #300)

Changes

Fix the alert container position to always be below the navigation bar.
Always display the success notification after when the test succeed

How to test this PR

Position

Try fetching data for a non existing domain.
Check that the notification is displayed.
Try to scroll, the notification should be sticky below the navigation bar.

Notification not always displayed

Create a test from the result page for a different domain
Check that the success notification is displayed