search

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project
Other
14 stars 22 forks source link

Modules names should not be uppercase #437

Closed hannaeko closed 7 months ago

hannaeko commented 1 year ago

The name of the module (as well of test cases for that matter) are uppercase. This cause screen readers to read them like acronyms (C-O-N-S-I-S-T-E-N-C-Y) instead of words (Consistency). I open the issue here but I think the fix should come from engine, this is were the current strings come from, so that we avoid hacks in GUI to fix that.

matsduf commented 1 year ago

I am not against the change, but I disagree that the fix should come from Engine or GUI. The change should come in the specification. We should define what it should be there, and then implement it in different places. The following document could be a start: https://github.com/zonemaster/zonemaster/blob/master/docs/internal/templates/specifications/tests/TestCaseIdentifierSpecification.md

hannaeko commented 1 year ago

I said Engine because in the current implementation that is where they are coming from. I guess it would be better if the spec is changed.

matsduf commented 1 year ago

My point is that we should not change in Engine before we specify the format in the specification. And with specification I do not mean each test case specification, but a specification of how those should be written.

hannaeko commented 1 year ago

Okay I will make a proposal.

hannaeko commented 7 months ago

Fixed with 2023.2