search

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project
Other
14 stars 22 forks source link

GUI returns HTTP code 200 when 404 is expected #442

Open matsduf opened 11 months ago

matsduf commented 11 months ago

If running https://zonemaster.net/en/fsdfdsfs the page says "Error 404" but the HTTP result code is 200.

rhedman commented 11 months ago

Should this really be handled by the application? Seems like something that should be handled in the web server instead? I suggest having language specific html-files for this that the web server could redirect to e.g in each language folder there will be a 404.html file. This also gives the option to modify the information in the files, like adding links to History -1 or the startpage.

hannaeko commented 10 months ago

As the routing is done by the application there is no way on doing that on the web server with the current architecture.

We would need to remove angular for that.

rhedman commented 10 months ago

As the routing is done by the application there is no way on doing that on the web server with the current architecture.

We would need to remove angular for that.

Another good reason to ditch Angular then :)