search

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project
Other
14 stars 23 forks source link

Fix unspecified #444

Closed hannaeko closed 10 months ago

hannaeko commented 11 months ago

Purpose

Fix the handling of unspecified messages following https://github.com/zonemaster/zonemaster-engine/pull/1302

Context

based on #434 https://github.com/zonemaster/zonemaster-engine/pull/1302

Changes

The unspecified messages are displayed above other messages and not collapsed, regardless of the case of "Unspecified".

Relevant commit : 6a2a7ad9f145d2a88a6760793516e82031c0751f

How to test this PR

Consult a test result of a domain tested after and before the change in https://github.com/zonemaster/zonemaster-engine/pull/1302.

Screenshot of the Basic and Address module in GUI result showing unspecified log entries above entries from test cases

What this PR fixes:

Screenshot of the Basic and Address module in GUI where unspecified log entries are under an UNSPECIFIED heading

matsduf commented 11 months ago

I do not understand what you want to change with this PR and how. And not why. What problem does it solve?

hannaeko commented 11 months ago

I updated the description with a screenshot of how it looks when displaying a test result that has been run with the engine version from https://github.com/zonemaster/zonemaster-engine/pull/1302

hannaeko commented 10 months ago

Rebased on top of develop, please re-review.

tgreenx commented 9 months ago

v2023.2 Release testing

Works as expected.