Closed hannaeko closed 3 months ago
What if you type something in the domain text field? Shouldn’t a button appear in the right hand side of the text box?
What if you type something in the domain text field? Shouldn’t a button appear in the right hand side of the text box?
Do you mean the "(x)" button?
Do you mean the "(x)" button?
Yes, that’s the button.
How to test this PR
Move the focus back to the domain input
* Enter "domain" in the domain input * Tab to the "Clear domain input" button * Press Enter * Check that the domain input is now empty and that the focus is back to the domain input
It is not.
Move the focus to the delete button
* Enter "1" in the first nameserver name input * Enter "2" in the second nameserver name input * Tab to the second delete button * Press Enter * Check that the focus is still on the second delete button but there are only two row now
It is not.
* Press Enter * Check that nothing has changed (the last row is not deleted to ensure that an empty row is alway present) * Tab back to the first delete button * Press Enter * Check that the focus is still on first delete button, there is now only one row and it is empty
Unclear.
Do you mean the "(x)" button?
Yes, that’s the button.
I was looking for a button with that name. Anyway, it is not working. I am not sure how important it is.
I have checked this PR and everything is good for me.
@matsduf when you say "it is not working" can you describe a bit more what does or does not happen (is the input not being cleared or the focus not being in the right place, etc.)? Also which browser are you using (I doubt that it matters but we never know)?
I have retested those parts on both Firefox and Chromium without issue.
As for the test that is "unclear", what information is lacking for you to do it?
@matsduf when you say "it is not working" can you describe a bit more what does or does not happen (is the input not being cleared or the focus not being in the right place, etc.)? Also which browser are you using (I doubt that it matters but we never know)?
I write something in the domain field and press tab to the (x) and press enter. After that the "cursor" is in some undefined place. I have to click the mouse button to get into the field gain to be able to write.
I am using Firefox, and now testing Chrome gives the same result.
As for the test that is "unclear", what information is lacking for you to do it?
Since it did not behave well it was hard to follow the instructions.
I write something in the domain field and press tab to the (x) and press enter. After that the "cursor" is in some undefined place. I have to click the mouse button to get into the field gain to be able to write.
This PR should be correcting this behaviour (it is the current one), is your test instance/VPS publicly available if I want to check?
This PR should be correcting this behaviour (it is the current one), is your test instance/VPS publicly available if I want to check?
It is on AWS and if you could provide an IP address (or both v4 and v6) I can open for you in the firewall.
It is on AWS and if you could provide an IP address (or both v4 and v6) I can open for you in the firewall.
I've sent you an email with my IP addresses.
It looks that the code that you are testing is not the one from this PR
Followed the "How to Test" section, and it works as advertised.
Purpose
Reposition the focus on various action and fix NS and DS new row handling.
Context
Addresses #446
Changes
detail
element (equivalent behaviour)How to test this PR
Move the focus back to the domain input
Move the focus to the delete button
Move the focus to first invalid input (client side validation, keyboard navigation)
Move the focus to first invalid input (client side validation, mouse navigation)
Move the focus to first invalid input (server side validation)
Missing error message for keytag