Closed hannaeko closed 2 months ago
My approval is based on the assumption that names of custom modules are just untranslated, and not creating any other issue
This was not the case and should now be fixed.
That’s a limitation of the current design. Shouldn’t these module names be moved over to Zonemaster::Engine, eventually?
I implemented this based on the decision taken in #86 to only translate in Gui but I guess this issue is a bit old now and things have changed since ^^
I implemented this based on the decision taken in #86 to only translate in Gui but I guess this issue is a bit old now and things have changed since ^^
I think that is fine for now. We can take the next step later.
@tgreenx and @marc-vanderwal, please re-review.
Followed the "How to Test" section, using the fr
locale, and it works as advertised.
Purpose
Translate severity levels and module names
Context
Fixes #86
Changes
How to test this PR