Translate severity levels and module names in result page

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project

Other

14 stars 22 forks source link

Translate severity levels and module names in result page #463

Closed hannaeko closed 2 months ago

hannaeko commented 6 months ago

Purpose

Translate severity levels and module names

Context

Fixes #86

Changes

Translate severity levels
Translate modules names

How to test this PR

Load a test result in a language that is not English and have the translation done
Check that the module names are translated
Check that the tooltip of the severity levels in module and test case heading icon are translated
Check that the severity levels in test case messages are translated

hannaeko commented 3 months ago

My approval is based on the assumption that names of custom modules are just untranslated, and not creating any other issue

This was not the case and should now be fixed.

That’s a limitation of the current design. Shouldn’t these module names be moved over to Zonemaster::Engine, eventually?

I implemented this based on the decision taken in #86 to only translate in Gui but I guess this issue is a bit old now and things have changed since ^^

matsduf commented 3 months ago

I implemented this based on the decision taken in #86 to only translate in Gui but I guess this issue is a bit old now and things have changed since ^^

I think that is fine for now. We can take the next step later.

matsduf commented 3 months ago

@tgreenx and @marc-vanderwal, please re-review.

tgreenx commented 2 months ago

v2024.1 Release testing

Followed the "How to Test" section, using the fr locale, and it works as advertised.