Display idn in both ascii and unicode forms

hannaeko commented 6 months ago

Purpose

Following 2023.2 release IDN are always normalized in ASCII in database, to be more user friendly this PR convert them back to unicode to be displayed on the result page. It also displayed the ASCII form in bracket.

This changes nothing for non-IDN.

Context

Fixes #198

Changes

Always convert domain to their Unicode form in title and result heading
Also display ASCII domain for IDN
The file name of the exported result uses the ASCII domain

Screenshot of the result heading containing the Unicode and ASCII forms of the same domain

How to test this PR

Ideally make the test using a backend < 2023.2 and with backend >= 2023.2, to see how it behaves when the returned domain is in ASCII and Unicode, and check that both should behave the same way.

Display the result of a test of an IDN
The page title must contain the Unicode domain
The result heading must show both the Unicode and ASCII domains

MichaelTimbert commented 3 months ago

Tested and working.

MichaelTimbert commented 2 months ago

I have successfully tested this PR on both Ubuntu 20.04.6 and 22.04.4. Both GUI display ASCII domain for IDN and all file name of the exported result uses the ASCII domain.

As mentioned in the PR i have tried to use older backend version (v10.0.0 & v10.0.2) but each time i get an error 500 from the backend.

zonemaster / zonemaster-gui