search

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project
Other
14 stars 22 forks source link

Close history modal #465

Closed hannaeko closed 2 months ago

hannaeko commented 6 months ago

Purpose

No indication (visual or not) are given to the user to signal that the new test results have been fetched.

Context

Fixes #242

Changes

Close the history modal when a link is clicked and move focus to the result heading (h2).

Limitation (maybe future work) : if the result request takes some time the focus would be moved to the old title and there would not be a indication when the new results have been received.

How to test this PR

(Better to test with a screen reader)

MichaelTimbert commented 3 months ago

Tested and working.

matsduf commented 3 months ago

@hannaeko, can you resolve the conflict?

hannaeko commented 3 months ago

@hannaeko, can you resolve the conflict?

The conflict has been resolved :)

tgreenx commented 2 months ago

@matsduf @marc-vanderwal @MichaelTimbert please re-review, conflict has been fixed, this can then be merged.

tgreenx commented 2 months ago

v2024.1 Release testing

Works as advertised on Firefox, Debian 12.