Cleanup old FAQ architecture files

zonemaster / zonemaster-gui

The Zonemaster GUI - part of the Zonemaster project

Other

14 stars 22 forks source link

Cleanup old FAQ architecture files #466

Closed hannaeko closed 3 months ago

hannaeko commented 6 months ago

Purpose

Remove unused FAQ files and scripts

Context

Following #434 some files are not used any more as the FAQ now use the common translation system.

Changes

Remove docs/FAQ/*
Remove scripts/faq.js
Remove unused dependency showdown (markdown to html renderer)
Update the translation guide

How to test this PR

Building the release (npm run release) should work.

marc-vanderwal commented 5 months ago

I had a look around and I found src/assets/faqs/.gitkeep but no mentions of faqs being assets. Do we still need this directory or would it make sense to remove that file too?

The build system still generates files in the src/assets/faqs directory, so this directory is still needed.

hannaeko commented 5 months ago

Not anymore, the script that used it has been remove with this PR, I removed the .gitkeep, thanks for noticing :)

tgreenx commented 2 months ago

v2024.1 Release testing

Following the "How to test" section, npm run release does run without issue. Also, the FAQ remains correctly translated.