zonemaster / zonemaster-ldns

A Perl interface module for Zonemaster to NLnet Labs' ldns library
Other
8 stars 12 forks source link

Migrate to libidn2? #131

Closed ghost closed 2 years ago

ghost commented 2 years ago

Our current implementation uses libidn and the libidn README says:

The IDNA2003 specifications have been superseded by IDNA2008 which is implemented by Libidn2 https://www.gnu.org/software/libidn/#libidn2, and the only reasonable use of the libidn library today is to support the historic IDNA2003 behaviour or to use Stringprep profiles. Please try to migrate to libidn2 wherever possible.

Should we therefore migrate to libidn2?

matsduf commented 2 years ago

Yes, Zonemaster should support IDNA 2008. Stringprep has been moved out of the core protocol, but parts of it are still valid. That has been incorporated in the proposed update of Basic00 (https://github.com/zonemaster/zonemaster/pull/942).

matsduf commented 2 years ago

Do you know if LDNS has support for libidn2?

ghost commented 2 years ago

Do you know if LDNS has support for libidn2?

From what I've seen, the IDN support is handled by Zonemaster::LDNS:

https://github.com/zonemaster/zonemaster-ldns/blob/001a9835bbc92367f8bab4228010c62872f7ffba/include/LDNS.h#L15-L17

https://github.com/zonemaster/zonemaster-ldns/blob/001a9835bbc92367f8bab4228010c62872f7ffba/src/LDNS.xs#L11-L37

ghost commented 2 years ago

Converting from libidn: https://libidn.gitlab.io/libidn2/manual/libidn2.html#Converting-from-libidn

matsduf commented 2 years ago

Resolved by #113.

matsduf commented 2 years ago

resolved by #133