search

zoneminder-containers / zoneminder-base

An always up-to-date automatically building ZoneMinder container
101 stars 32 forks source link

move environment's out of version control #12

Closed ZhoraKornev closed 3 years ago

ZhoraKornev commented 3 years ago

Yep - i hope you will develop this repo to production mode. It's looking good you use releases and auto git scripts. Nice work bro.

alexyao2015 commented 3 years ago

Thanks. I don't believe these changes are really necessary. The .env file there is to serve as an example. The port mapping can be changed in the docker-compose file. There doesn't seem to be a clear purpose to mapping it to the env file.

ZhoraKornev commented 3 years ago

but not evryone have stand alone server so config ports and secrets out of version control must have

alexyao2015 commented 3 years ago

Sure you can still configure the ports on your own copy of the .env file or docker-compose file. Those are just examples.

ZhoraKornev commented 3 years ago

the .env file under version control and on new pulls it can be overwriting! Bad bractice.