search

zonkyio / embedded-database-spring-test

A library for creating isolated embedded databases for Spring-powered integration tests.
Apache License 2.0
399 stars 37 forks source link

Spring 5.3.24, Spring Boot 2.7.6 #217

Closed julianladisch closed 1 year ago

julianladisch commented 1 year ago

Upgrading Spring from 5.0.20 to 5.3.24 fixes Spring4Shell: https://nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-22965

Upgrading Spring Boot from 2.0.9 to 2.7.6 fixes Insecure Temporary File: https://nvd.nist.gov/view/vuln/detail?vulnId=CVE-2022-27772

tomix26 commented 1 year ago

It seems that the tests failed because of missing the ACCEPT_LICENCE property, which is required to run MSSQL docker containers. So could you please add the following secret to your repo: ACCEPT_LICENCE=true.

Here are detailed instructions: https://docs.github.com/en/actions/security-guides/encrypted-secrets

julianladisch commented 1 year ago

I've set the secret on December 1st and it works on my respository: https://github.com/julianladisch/embedded-database-spring-test/actions You need to restart the check GitHub Actions in zonkyio repository because I don't have permissions.

tomix26 commented 1 year ago

Ok, that's weird, because other pull requests are building fine. I've tried to merge it, so let's see how the tests run in the master branch.

tomix26 commented 1 year ago

In the master branch all the tests passed. So everything looks fine. I really don't know what the problem was. Anyway, thanks a lot for preparing the pull request!