search

zonradkuse / covid-data-processing

Plots and other data processing using JHUs covid 19 data
2 stars 3 forks source link

Modularity cleanup #21

Closed gonuke closed 4 years ago

gonuke commented 4 years ago

Major refactor of semilog plots since a threshold to accomplish more code reuse. Add substantial documentation.

Minor refactor of data loading and parsing to provide more flexibility at the interface and prepare for state and county level plotting. In particular, this is on a path to read the data from the source less often. Right now, many plotting functions read data from the source each time they are called.

Removed reference to recovered data since it is no longer reliable data.

Replaces #18 and #20

zonradkuse commented 4 years ago

This looks, again, really good. Thank you!

One thing I notice is the removal of the figure return. If I got it right this causes jupyter notebooks to plot twice? I wanted to use this as a framework to plot arbitrary graphs into a (more or less) interactive dashboard. I'll have time again tomorrow to experiment.

gonuke commented 4 years ago

Yes... I haven't bothered to load the packages to test what you are doing. I'm happy to leave it in, but you have correctly determined why I wanted it gone. I can possibly figure out a different solution if that won't work for you. I could wrap the functions to capture the return and then not pass it through.

Let me know...

gonuke commented 4 years ago

I added the return and things still work fine on my end....

zonradkuse commented 4 years ago

I'll merge it then.