zood / george

Zood Location client for Android
GNU Affero General Public License v3.0
60 stars 8 forks source link

Make app available via F-Droid #67

Open arashpayan opened 3 years ago

arashpayan commented 3 years ago

The app doesn't currently meet the requirements for inclusion in F-Droid. Things that would need to be changed/removed/optional:

IzzySoft commented 3 years ago

While approaching these culprits one-by-one, you can watch progress e.g. here – I've just added your app to my repo. Scroll down to the library section and toggle the "xx libraries detected" field, it will then reveal details. Libraries marked by a Ⓓ (Non-Free Dependency) or Ⓝ (Non-Free Network) are the current culprits (luckily no Ⓣ like Tracking among them – thanks!) – at the time of this writing, there are 4 of those. Watch them disappear while tackling the issue here :smiley:

arashpayan commented 3 years ago

hey @IzzySoft. On the Zood Location page of your F-Droid repo where it mentions that Firebase is in the app, does it take it account the 3 excludes I'm using in my build.gradle to make sure the undesirable elements of Firebase are not included in the app? Here's the snippet in question from my build.gradle file:

    implementation ('com.google.firebase:firebase-messaging:20.2.1', {
        exclude group: 'com.google.firebase', module: 'firebase-core'
        exclude group: 'com.google.firebase', module: 'firebase-analytics'
        exclude group: 'com.google.firebase', module: 'firebase-measurement-connector'
    })
IzzySoft commented 3 years ago

My library scanner doesn't look at the build.gradle – it looks inside the APK (the smali code generated by apktool). And there it finds e.g.

com/google/android/gms/internal/firebase_messaging
com/google/firebase/annotations
com/google/firebase/components
com/google/firebase/datatransport
com/google/firebase/encoders/config
com/google/firebase/encoders/json
com/google/firebase/events
com/google/firebase/heartbeatinfo
com/google/firebase/iid/internal
com/google/firebase/inject
com/google/firebase/installations/interop
com/google/firebase/installations/local
com/google/firebase/installations/remote
com/google/firebase/internal
com/google/firebase/messaging
com/google/firebase/platforminfo
com/google/firebase/provider

(and some more GMS hits)

minax007 commented 2 years ago

As this app is open source compared to most other similar apps it would certainly increase the popularity to have it also in the base repository of F-Droid.

Background: Most of the F-Droid users are not using any other repository than the base repository. And apps from other repositories are also not advertised on the F-Droid website.

Kreuger commented 10 months ago

This has been open for 3 yrs. Has there been any progress made?