zoom / videosdk-ui-toolkit-web

The Zoom Video SDK UI toolkit is a prebuilt video chat user interface powered by the Zoom Video SDK.
https://www.npmjs.com/package/@zoom/videosdk-ui-toolkit
Other
9 stars 8 forks source link

Activate screen share for every participants #26

Closed misterdebug closed 1 week ago

misterdebug commented 1 month ago

Hi,

First of all, congratulations on all the work done for this toolkit :) I would like to enable screen sharing for everyone, and from what I understand of the code, only the host can do it sharePrivilege: vo.OnlyHost.

I found this part to change the button back to blue: $("ngClass", 1 !== o.videoSdkService.stream.getSharePrivilege() || null != (e = Yi(1, 2, o.currentUser$)) && e.isHost ? "ctrl-btn" : "ctrl-btn grey")("disabled", 1 === o.videoSdkService.stream.getSharePrivilege() && !(null != (n = Yi(2, 4, o.currentUser$)) && n.isHost)) And I found this part too : if (S === vo.OnlyHost && !K) return Promise.reject({ type: to, reason: "only host can start screen share" });

There is a more elegant way to do it? Or is it possible to add this feature? Thanks

tommygaessler commented 1 month ago

Hey @misterdebug , thank you!

Screensharing is enabled for everyone by default. Can you clarify what you are trying to do?

tommygaessler commented 1 week ago

Closing due to no activity, please reopen if the issue persists.

misterdebug commented 1 week ago

Hi @tommygaessler, I always have the same problem when I open a discussion between 2 people: one has the share button (blue button that triggers sharing) and the other has the greyed-out button (and when clicked, nothing happens).

tommygaessler commented 1 week ago

Hey @misterdebug , can you please share a screenshot of the grayed-out button?

misterdebug commented 1 week ago

Hi @tommygaessler, here a screenshot, 1st person (on the left) has blue button but the 2nd one (on the right) has grey button 1725612670-Capture-d’écran-2024-09-06-105029

tommygaessler commented 4 days ago

Hey @misterdebug , the button will be disabled if the host has disabled screen sharing.

Have you disabled screensharing via any Video SDK function?

misterdebug commented 3 days ago

Hi @tommygaessler, I didn't even know it was possible haha. No, I only use the kit.