zoometh
commented
3 years ago As usual, I've merged your requests with the main without testing them before (I guess you have). I will make all the required tests after lunch and before meeting Craig.
Closed josempozo closed 3 years ago
zoometh
commented
3 years ago As usual, I've merged your requests with the main without testing them before (I guess you have). I will make all the required tests after lunch and before meeting Craig.
zoometh
commented
3 years ago I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges
Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to *eds* functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
josempozo
commented
3 years ago Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731751601, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA .
zoometh
commented
3 years ago Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo notifications@github.com wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731751601, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA .
zoometh
commented
3 years ago Solved !
On Sun, Nov 22, 2020 at 5:05 PM Thomas Huet thomashuet7@gmail.com wrote:
Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo notifications@github.com wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731751601, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA .
josempozo
commented
3 years ago Hola Thomas,
He conseguido unir "plot_eds_compar" y "plot_nds_compar" (en un "plot_compar") y "side_plot_eds" y "side_plot_nds" (en "side_plot"). También tengo listo unir list_eds_compar y list_nds_compar.
¿Qué te parece esta unión? La diferencia para el usuario estaría en un parámetro (focus = "nodes" o focus = "edges"). Esto cambia la forma como el usuario debe interactuar. También podría dejar las interficies actuales (las versiones eds i nds), que llamarían a la general internamente. ¿Qué te parece mejor?
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dl., 23 de nov. 2020 a les 8:08:
Solved !
On Sun, Nov 22, 2020 at 5:05 PM Thomas Huet thomashuet7@gmail.com wrote:
Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo notifications@github.com wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731751601, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731970559, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2JLTGBL5EC4FEQQH2LSRIC6RANCNFSM4T5LRPRA .
zoometh
commented
3 years ago Hola Jose,
Me parece muy bien: "the shorter is the better". Luego, cambiaremos las vignettes y el articulo
Yo trabajo sobre el articulo, con algunas dificultades con el layout (más que todo con malditos espacios y malditas margines). Espero acabar este fin de semana. Desde entonces, enviaré a Craig un mensaje para que el se anime un poco más.
Un abrazo
On Thu, Nov 26, 2020 at 4:11 PM josempozo notifications@github.com wrote:
Hola Thomas,
He conseguido unir "plot_eds_compar" y "plot_nds_compar" (en un "plot_compar") y "side_plot_eds" y "side_plot_nds" (en "side_plot"). También tengo listo unir list_eds_compar y list_nds_compar.
¿Qué te parece esta unión? La diferencia para el usuario estaría en un parámetro (focus = "nodes" o focus = "edges"). Esto cambia la forma como el usuario debe interactuar. También podría dejar las interficies actuales (las versiones eds i nds), que llamarían a la general internamente. ¿Qué te parece mejor?
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dl., 23 de nov. 2020 a les 8:08:
Solved !
On Sun, Nov 22, 2020 at 5:05 PM Thomas Huet thomashuet7@gmail.com wrote:
Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo notifications@github.com wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731751601, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731970559, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ARKCR2JLTGBL5EC4FEQQH2LSRIC6RANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-734350995, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQGHHLQ3ESUBZ4Y6RDC7RSLSRZVZ7ANCNFSM4T5LRPRA .
josempozo
commented
3 years ago Hola Thomas,
He propuesto bastantes cambios. Pero queda cambiar las vignettes de acuerdo con ellos. He cambiado un poco en decorr.Rmd, aunque no del todo. Tal vez podemos acabar la documentación durante la semana que viene.
Estoy mirando ahora de simplificar "same_eds". Creo que se puede hacer muy bien usando la función "named_edges" que he incluido en el archivo "list_compar.R". Pero necesito saber si los mensajes que se dan con "verbose = TRUE" son importantes. En "same_nds" no había ninguno. Y dejarlos complica mucho las cosas.
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dv., 27 de nov. 2020 a les 10:50:
Hola Jose,
Me parece muy bien: "the shorter is the better". Luego, cambiaremos las vignettes y el articulo
Yo trabajo sobre el articulo, con algunas dificultades con el layout (más que todo con malditos espacios y malditas margines). Espero acabar este fin de semana. Desde entonces, enviaré a Craig un mensaje para que el se anime un poco más.
Un abrazo
On Thu, Nov 26, 2020 at 4:11 PM josempozo notifications@github.com wrote:
Hola Thomas,
He conseguido unir "plot_eds_compar" y "plot_nds_compar" (en un "plot_compar") y "side_plot_eds" y "side_plot_nds" (en "side_plot"). También tengo listo unir list_eds_compar y list_nds_compar.
¿Qué te parece esta unión? La diferencia para el usuario estaría en un parámetro (focus = "nodes" o focus = "edges"). Esto cambia la forma como el usuario debe interactuar. También podría dejar las interficies actuales (las versiones eds i nds), que llamarían a la general internamente. ¿Qué te parece mejor?
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dl., 23 de nov. 2020 a les 8:08:
Solved !
On Sun, Nov 22, 2020 at 5:05 PM Thomas Huet thomashuet7@gmail.com wrote:
Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo notifications@github.com wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/zoometh/iconr/pull/11#issuecomment-731751601 , or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731970559, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2JLTGBL5EC4FEQQH2LSRIC6RANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-734350995, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQGHHLQ3ESUBZ4Y6RDC7RSLSRZVZ7ANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-734747616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2M2YFYLOIP5WRPSMT3SR5ZAFANCNFSM4T5LRPRA .
josempozo
commented
3 years ago Otra pregunta,
Los grafos 2 ("Torrejon Rubio") y 4 ("Zarza de Montanchez") contienen aristas (edges) repetidas: "chariot_char--cheval" y "chariot_char--roue". Curiosamente las mismas dos en los dos grafos. ¿Es esto un error o tiene algún significado?
Saludos
Jose
Missatge de Jose Pozo josmpozo@gmail.com del dia dv., 27 de nov. 2020 a les 17:01:
Hola Thomas,
He propuesto bastantes cambios. Pero queda cambiar las vignettes de acuerdo con ellos. He cambiado un poco en decorr.Rmd, aunque no del todo. Tal vez podemos acabar la documentación durante la semana que viene.
Estoy mirando ahora de simplificar "same_eds". Creo que se puede hacer muy bien usando la función "named_edges" que he incluido en el archivo "list_compar.R". Pero necesito saber si los mensajes que se dan con "verbose = TRUE" son importantes. En "same_nds" no había ninguno. Y dejarlos complica mucho las cosas.
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dv., 27 de nov. 2020 a les 10:50:
Hola Jose,
Me parece muy bien: "the shorter is the better". Luego, cambiaremos las vignettes y el articulo
Yo trabajo sobre el articulo, con algunas dificultades con el layout (más que todo con malditos espacios y malditas margines). Espero acabar este fin de semana. Desde entonces, enviaré a Craig un mensaje para que el se anime un poco más.
Un abrazo
On Thu, Nov 26, 2020 at 4:11 PM josempozo notifications@github.com wrote:
Hola Thomas,
He conseguido unir "plot_eds_compar" y "plot_nds_compar" (en un "plot_compar") y "side_plot_eds" y "side_plot_nds" (en "side_plot"). También tengo listo unir list_eds_compar y list_nds_compar.
¿Qué te parece esta unión? La diferencia para el usuario estaría en un parámetro (focus = "nodes" o focus = "edges"). Esto cambia la forma como el usuario debe interactuar. También podría dejar las interficies actuales (las versiones eds i nds), que llamarían a la general internamente. ¿Qué te parece mejor?
Saludos
Jose
Missatge de zoometh notifications@github.com del dia dl., 23 de nov. 2020 a les 8:08:
Solved !
On Sun, Nov 22, 2020 at 5:05 PM Thomas Huet thomashuet7@gmail.com wrote:
Hi Jose,
I had Craig via Whatsapp. He will edit the article during this week.
After some "human error" (mine) I have a problem with the imgs.tsv and imgs.csv headers...
[image: image.png]
I will arrange this tomorrow.
As I said to Craig, if everything works this week (no bugs, no unexpected supplementary work, etc.), we plan a meeting at the end of the week
Best
On Sun, Nov 22, 2020 at 4:14 PM josempozo <notifications@github.com
wrote:
Hi Thomas,
Yes, I will start them on Monday.
El dg., 22 de nov. 2020, 14:51, zoometh notifications@github.com va escriure:
I have add a lbl.size variable to plot_nds_compar() function so the user can increase or decrease labels of nodes/edges Could you make the same changes you've made for list_nds_compar, plot_nds_compar.R, plot_nds_compar.Rd, side_plot_nds.Rd to eds functions (list_eds_compar, plot_eds_compar.R, plot_eds_compar.Rd, side_plot_eds.Rd) and also add the lbl.size variable to plot_eds_compar.R ?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/zoometh/iconr/pull/11#issuecomment-731751601 , or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2NG5MD5BW2BXW6MRKDSREJM5ANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731762990, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/AQGHHLRXQP2WICHL6GV4SEDSRETFNANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-731970559, or unsubscribe <
https://github.com/notifications/unsubscribe-auth/ARKCR2JLTGBL5EC4FEQQH2LSRIC6RANCNFSM4T5LRPRA
.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-734350995, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQGHHLQ3ESUBZ4Y6RDC7RSLSRZVZ7ANCNFSM4T5LRPRA
.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/zoometh/iconr/pull/11#issuecomment-734747616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARKCR2M2YFYLOIP5WRPSMT3SR5ZAFANCNFSM4T5LRPRA .
Removed the selection of color and size for the common and different vertices. Only the flag indicating the fact of being common or different (V(g)$comm) is assigned. The colors and sizes corresponding to each of them are stated in the plot functions.